Make it possible to define TCXO and XTAL radio modules within one variant #4492
Conversation
Add in TCXO_OPTIONAL variable for tcxoVoltage and a double-check for working in both modes.
Make a change to the tcxoVoltage setting so that TCXO_OPTIONAL works if defined.
Added define for TCXO_OPTIONAL and the tcxoVoltage variable. Added detail on the compatible boards.
|
This is great! I think there are also TXCO variants in the TLoRA line that have required specific pio targets, so we can perhaps try this on them. Anytime we can consolidate, I'm on board. |
I think I've made this universal enough, so just adding Anyway, I'm calling this good enough for now. |
|
@thebentern I keep getting notifications on this. Do I need to do something to make it merge properly? |
|
This is a good idea. Hopefully the radio initialisation always fails when there is no TCXO when expecting one, instead of succeeding and causing problems in later stages.
|
This changes the way that the SX1262 is initialised, so that if it fails to initialise with the DIO3 voltage reference set, it will retry with the voltage set to zero. By this, there is no need to fully define whether the attached radio has TCXO or not during compile.
This is mainly for the pro-micro variant, but will work with other DIY boards or variants that come in both flavours. Potential candidates are the RP2040 modules, as there are some low-cost versions that utilise the same cheap modules.
Huge credit to Todd Herbert (@todd-herbert) for doing so much of the heavy lifting and heavy thinking associated with this. It would not have been possible to do this without you!